Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to cache encrpytion keys in the player #446

Merged
merged 7 commits into from
Apr 1, 2019
Merged

feat: add option to cache encrpytion keys in the player #446

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f2c2299
add option to cache encrpytion keys in the player
mjneil Mar 28, 2019
5de9997
a bit of cleanup
mjneil Mar 28, 2019
dbde4be
add option to readme
mjneil Mar 28, 2019
e721740
add as source option as well
mjneil Mar 28, 2019
57fe74c
add todo comment about HTTP Expires header
mjneil Mar 28, 2019
13a749a
remove iv leak
mjneil Mar 28, 2019
948a122
add unit and integration tests (#448)
ldayananda Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/segment-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,8 @@ export default class SegmentLoader extends videojs.EventTarget {
const id = initSegmentId(map);
let storedMap = this.initSegments_[id];

// TODO: We should use the HTTP Expires header to invalidate our cache per
// https://tools.ietf.org/html/draft-pantos-http-live-streaming-23#section-6.2.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, this accidentally ended up in the initSegment method instead of segmentKey

if (set && !storedMap && map.bytes) {
this.initSegments_[id] = storedMap = {
resolvedUri: map.resolvedUri,
Expand Down