fix: Prevent exceptions from being thrown by the MediaSource #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Jan 25, 2019
brandonocasey
commented
Jan 25, 2019
| try { | ||
| this.mediaSource.duration = newDuration; | ||
| } catch (e) { | ||
| videojs.log.warn('Failed to set media source duration', e); |
There was a problem hiding this comment.
I tried for a long time to determine the cause of this, it almost seems like a bug in firefox. Originally I thought it was due to updating sourceBuffers or the media source not being open but that is not the case.
brandonocasey
force-pushed
the
fix/media-source-exceptions
branch
from
76bc2da to
7f4c552
Compare
brandonocasey
commented
Jan 28, 2019
| return; | ||
| } | ||
|
|
||
| // on chrome calling endOfStream can sometimes cause an exception, |
There was a problem hiding this comment.
Chrome can sometimes throw a DOM exception here when endOfStream is called. It seems like it almost always happens when:
sourceBuffersare still updating- The
mediaSourceis no longeropen
It does seem to happen at other times though. So I think we just need to wrap this in a try catch here.
misteroneill
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See code comments