fix: use startTime instead of 0 for finiteDuration #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dzianis-dashkevich a fix from a while ago that you brought to my attention re #1411. |
dzianis-dashkevich
approved these changes
Nov 20, 2023
|
With "@videojs/http-streaming": "3.0.2" the cues worked as expected and they get active because the endTime was set to Infinity. Then the endTime of a cue was set to "0" and the stoped working, they don't get active and not event dispatch. Now in the latest version "@videojs/http-streaming": "3.8.0" the endTime is set to the startTime... okay. sounds for me like an improvement... but the cue doesn't get active too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We shouldn't set endTime to 0, instead we should set it to the startTime if we don't have a duration.
Specific Changes proposed
replace 0 with startTime
Requirements Checklist