-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Content Steering HLS Pathway Cloning #1432
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1432 +/- ##
==========================================
- Coverage 85.98% 85.33% -0.66%
==========================================
Files 42 42
Lines 10428 12305 +1877
Branches 2412 2928 +516
==========================================
+ Hits 8967 10501 +1534
- Misses 1461 1804 +343
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a couple of questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great overall, 1 minor style question.
Description
Implementation for HLS Pathway cloning for content steering. See the spec here: https://datatracker.ietf.org/doc/draft-pantos-hls-rfc8216bis/
Whenever we get a response from the content server with a
PATHWAY-CLONES
array, we need to add, update, or delete playlists and media based on the data we receive. A pathway clone object tells us information about a new pathway that should be created/updated based off of another pathway.Specific Changes proposed
Requirements Checklist