Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: content steering switching #1427

Merged
merged 24 commits into from
Sep 26, 2023
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
09276dd
feat: add steering switching
adrums86 Aug 31, 2023
1e6583b
switch audio and text playlists on switch for DASH
wseymour15 Aug 31, 2023
f2278e0
steering request error handling
wseymour15 Sep 1, 2023
6f9af6a
queryBeforeStart support and switching logic improvement
wseymour15 Sep 5, 2023
8bab119
remove demo html
adrums86 Sep 5, 2023
1805722
fix DASH playlist switching
adrums86 Sep 6, 2023
7c17c32
live dash content steering support
wseymour15 Sep 7, 2023
980cfd8
slight improvement to queryBeforeStart
wseymour15 Sep 7, 2023
418c703
finish playlist exclusion logic
adrums86 Sep 7, 2023
e42bd9c
fix tests
adrums86 Sep 7, 2023
b1337e8
minor fixes and tests
wseymour15 Sep 7, 2023
33bbeb7
minor improvements to queryBeforeStart
wseymour15 Sep 7, 2023
813f8dd
add DASH specific logic back to exclude function
adrums86 Sep 7, 2023
e2927ce
tests for live content steering
wseymour15 Sep 11, 2023
2ba74c5
playlist controller tests
wseymour15 Sep 12, 2023
50f9a48
tests for content steering controller
wseymour15 Sep 13, 2023
d3d5f60
minor test updates
wseymour15 Sep 13, 2023
65f1016
remove stopLoader from subtitle onError
wseymour15 Sep 14, 2023
e882de5
improvements based on comments
wseymour15 Sep 18, 2023
9465337
update requestSteeringManifest to use uri
wseymour15 Sep 18, 2023
5604ea5
minor changes based on comments
wseymour15 Sep 19, 2023
c9d470d
remove unecessary error property
wseymour15 Sep 19, 2023
5ee0b01
use bandwidth for throughput param
adrums86 Sep 21, 2023
72af63a
use xhr and bandwidth parameters
adrums86 Sep 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unecessary error property
wseymour15 committed Sep 19, 2023
commit c9d470d37b4ee6140af5bcfbcaf35a29c9026ffc
4 changes: 0 additions & 4 deletions src/content-steering-controller.js
Original file line number Diff line number Diff line change
@@ -83,7 +83,6 @@ export default class ContentSteeringController extends videojs.EventTarget {
this.manifestType_ = null;
this.ttlTimeout_ = null;
this.request_ = null;
this.requestError_ = null;
this.excludedSteeringManifestURLs = new Set();
this.mainSegmentLoader_ = segmentLoader;
this.logger_ = logger('Content Steering');
@@ -164,7 +163,6 @@ export default class ContentSteeringController extends videojs.EventTarget {
uri
}, (error, errorInfo) => {
if (error) {
this.requestError_ = error;
// If the client receives HTTP 410 Gone in response to a manifest request,
// it MUST NOT issue another request for that URI for the remainder of the
// playback session. It MAY continue to use the most-recently obtained set
@@ -195,7 +193,6 @@ export default class ContentSteeringController extends videojs.EventTarget {
this.startTTLTimeout_();
return;
}
this.requestError_ = null;
const steeringManifestJson = JSON.parse(this.request_.responseText);

this.startTTLTimeout_();
@@ -397,7 +394,6 @@ export default class ContentSteeringController extends videojs.EventTarget {
this.manifestType_ = null;
this.ttlTimeout_ = null;
this.request_ = null;
this.requestError_ = null;
this.excludedSteeringManifestURLs = new Set();
this.availablePathways_ = new Set();
this.excludedPathways_ = new Set();