fix(docs): Remove confusion around including VHS separately #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc example was confusing, leading some people to including a VHS separately. Makes it clearer that including the VHS script shouldn't be necessary, and when so to use the core video.js.
Codecov Report
@@ Coverage Diff @@
## main #1367 +/- ##
=======================================
Coverage 85.40% 85.40%
=======================================
Files 40 40
Lines 9963 9963
Branches 2308 2308
=======================================
Hits 8509 8509
Misses 1454 1454 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phloxic
reviewed
Feb 3, 2023
misteroneill
requested changes
Feb 23, 2023
Co-authored-by: Pat O'Neill <[email protected]>
Co-authored-by: Pat O'Neill <[email protected]>
gkatsev
approved these changes
Mar 14, 2023
misteroneill
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc example was confusing, leading some people to including a VHS separately. Makes it clearer that including the VHS script shouldn't be necessary, and when so to use the core video.js.
Description
Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.
Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist