-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: in manifest vtt ios mse issue (2.x) #1364
Merged
dzianis-dashkevich
merged 8 commits into
videojs:2.x
from
dzianis-dashkevich:2x/fix/in-manifest-vtt-ios-mse-issue
Jan 30, 2023
Merged
fix: in manifest vtt ios mse issue (2.x) #1364
dzianis-dashkevich
merged 8 commits into
videojs:2.x
from
dzianis-dashkevich:2x/fix/in-manifest-vtt-ios-mse-issue
Jan 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d for any reasons.
… we do not have it loaded
Codecov Report
@@ Coverage Diff @@
## 2.x #1364 +/- ##
=======================================
Coverage 86.34% 86.35%
=======================================
Files 39 39
Lines 9859 9871 +12
Branches 2299 2301 +2
=======================================
+ Hits 8513 8524 +11
- Misses 1346 1347 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wseymour15
approved these changes
Jan 30, 2023
alex-barstow
approved these changes
Jan 30, 2023
dzianis-dashkevich
added a commit
that referenced
this pull request
Jan 30, 2023
* fix: Add exception guard for VTT parsing state if vtt.js is not loaded for any reasons. * fix: Do not override native for all iOS/iPadOS browsers * fix: Add guard for vtt-segment-loader to actually load vtt.js in case we do not have it loaded * chore: fix eslit errors * chore: Add loadVttJs test * chore: Add test for parse exception if no vtt.js is loaded for any reason * chore: fix typo * chore: remove redundant default value --------- Co-authored-by: Dzianis Dashkevich <[email protected]>
alex-barstow
changed the title
2x/fix/in manifest vtt ios mse issue
fix: in manifest vtt ios mse issue (2.x)
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are cherry-picked commits from this PR: #1360
with fixed conflicts for 2.x
...
Description
We have a bug with default options setup for HLS in-manifest VTT in chrome iOS (and I assume other non-safari Webkit-based iOS browsers). The problem is that we do not load
vtt.js
, but we useVHS
to handle playback.vtt-segment-loader
implicitly depends onwindow.WebVTT.Parser
. Sincevtt.js
is not loaded -window.WebVTT
isundefined
. It means that we are not able to parse received VTT cues.Specific Changes proposed
vtt.js
invtt-segment-loader
if we do not have it loaded. (eg: forceoverrideNative
option case).Requirements Checklist