refactor: clean up parameters of excludePlaylist #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #1304 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 39 39
Lines 9791 9795 +4
Branches 2275 2277 +2
=======================================
+ Hits 8447 8451 +4
Misses 1344 1344
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gkatsev
approved these changes
Aug 4, 2022
src/master-playlist-controller.js
Outdated
Comment on lines
1149
to
1152
| // If the `error` was generated by the playlist loader, it will contain | ||
| // the playlist we were trying to load (but failed) and that should be | ||
| // excluded instead of the currently selected playlist which is likely | ||
| // out-of-date in this scenario |
There was a problem hiding this comment.
is this comment still correct? At the very least, we won't be using the error.playlist here anymore.
There was a problem hiding this comment.
Nice catch! I'll remove the whole comment.
gkatsev
approved these changes
Aug 4, 2022
misteroneill
approved these changes
Aug 19, 2022
Rename the parameters passed to excludePlaylist to make the logic easier to follow.
misteroneill
force-pushed
the
refactor/exclude-playlist
branch
from
f383b29 to
a689041
Compare
|
Rebased for @gesinger to resolve conflicts due to master/main renaming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the parameters passed to excludePlaylist to make the logic easier to follow.
Requirements Checklist