-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dts-based timestamp offset calculation with feature toggle.… #1251
feat: add dts-based timestamp offset calculation with feature toggle.… #1251
Conversation
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, thank you so much!
One possible additional test would be to use the muxedSegment
, which has different times between audio and video, to ensure that video is prioritized.
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, thank you @dzianis-dashkevich ! This is very much appreciated.
Codecov Report
@@ Coverage Diff @@
## main #1251 +/- ##
==========================================
+ Coverage 86.31% 86.35% +0.03%
==========================================
Files 39 39
Lines 9807 9817 +10
Branches 2279 2283 +4
==========================================
+ Hits 8465 8477 +12
+ Misses 1342 1340 -2
Continue to review full report at Codecov.
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Description
Introduced DTS-based
timestampOffset
calculation. Can be enabled with a feature flag.For more info please check: #1247
Requirements Checklist