Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add experimentalExactManifestTimings which forgoes TIME_FUDGE_FACTOR during segment choice #1165

Merged
merged 7 commits into from
Jul 27, 2021

Conversation

brandonocasey
Copy link
Contributor

Remove TIME_FUDGE_FACTOR from our calculations and just use manifest values.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #1165 (b26ddd3) into main (a0c0359) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
+ Coverage   86.49%   86.50%   +0.01%     
==========================================
  Files          39       39              
  Lines        9590     9599       +9     
  Branches     2214     2218       +4     
==========================================
+ Hits         8295     8304       +9     
  Misses       1295     1295              
Impacted Files Coverage Δ
src/master-playlist-controller.js 94.60% <ø> (ø)
src/videojs-http-streaming.js 90.30% <ø> (ø)
src/playlist.js 94.32% <100.00%> (+0.20%) ⬆️
src/segment-loader.js 96.22% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c0359...b26ddd3. Read the comment docs.

@brandonocasey brandonocasey changed the title fix: more accurate segment choice by removing TIME_FUDGE_FACTOR feat: Add experimentalExactManifestTimings which forgoes TIME_FUDGE_FACTOR during segment choice Jul 14, 2021
gesinger
gesinger previously approved these changes Jul 27, 2021
@brandonocasey brandonocasey merged commit 67a1201 into main Jul 27, 2021
@brandonocasey brandonocasey deleted the fix/more-accurate-segment-choice branch July 27, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants