fix: add tests for data uri, fix data uri in demo page #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
May 20, 2021
| @@ -400,7 +400,7 @@ | |||
| } | |||
|
|
|||
| if (source.src) { | |||
| stateEls.url.value = source.src; | |||
| stateEls.url.value = encodeURI(source.src); | |||
There was a problem hiding this comment.
without this data-uri's break the demo on reload.
Codecov Report
@@ Coverage Diff @@
## main #1133 +/- ##
==========================================
- Coverage 86.25% 86.22% -0.04%
==========================================
Files 39 39
Lines 9289 9289
Branches 2127 2127
==========================================
- Hits 8012 8009 -3
- Misses 1277 1280 +3
Continue to review full report at Codecov.
|
|
I see, vhs-utils fix will go here, cool |
gkatsev
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for, and as soon as we get a vhs-utils update, fixes data-uri type urls.