feat: usage on rendition change #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
chore/rendition-usage
branch
from
9ccb581 to
f44cb93
Compare
gkatsev
changed the title
gkatsev
changed the title
gesinger
reviewed
Mar 4, 2021
gkatsev
approved these changes
Mar 29, 2021
Codecov Report
@@ Coverage Diff @@
## main #1088 +/- ##
==========================================
+ Coverage 86.06% 86.08% +0.01%
==========================================
Files 38 38
Lines 8923 8931 +8
Branches 1998 2001 +3
==========================================
+ Hits 7680 7688 +8
Misses 1243 1243
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch all
this.masterPlaylistLoader.media_calls tothis.switchMedia_which will log the cause behind the switch as a triggered usage event.