chore: mirror player.src on the demo page demo page #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
previously approved these changes
Feb 16, 2021
index.html
Outdated
| @@ -88,6 +88,10 @@ <h3>Options</h3> | |||
| <input id=override-native type="checkbox" checked> | |||
| Override Native (reloads player) | |||
| </label> | |||
| <label> | |||
| <input id=mirror-source type="checkbox" checked> | |||
| Mirror sources from player.src (reloads player) | |||
There was a problem hiding this comment.
Should we just call this sourceset? This the target of these pages are us, we can be as technical as we want.
There was a problem hiding this comment.
At first I wanted to, but that isn't really the feature that we care about here. We care about mirroring sources from player.src, sourceset just happens to make that very easy to do.
There was a problem hiding this comment.
Maybe adding uses sourceset in the parens too.
My thought process here is that we always want mirroring but that it's possible that sourceset may cause issues so we'd want to disable it.
There was a problem hiding this comment.
I will do that and merge
gkatsev
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses sourceset to mirror the source that was set via
player.srcin the ui so that it will be saved on page reload!