-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not request manifests until play when preload is none #1060
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -279,7 +279,16 @@ export class MasterPlaylistController extends videojs.EventTarget { | |
this.logger_ = logger('MPC'); | ||
|
||
this.triggeredFmp4Usage = false; | ||
this.masterPlaylistLoader_.load(); | ||
if (this.tech_.preload() === 'none') { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. glad it's surprisingly simple. |
||
this.loadOnPlay_ = () => { | ||
this.loadOnPlay_ = null; | ||
this.masterPlaylistLoader_.load(); | ||
}; | ||
|
||
this.tech_.one('play', this.loadOnPlay_); | ||
} else { | ||
this.masterPlaylistLoader_.load(); | ||
} | ||
} | ||
|
||
/** | ||
|
@@ -381,6 +390,9 @@ export class MasterPlaylistController extends videojs.EventTarget { | |
}); | ||
|
||
this.masterPlaylistLoader_.on('loadedplaylist', () => { | ||
if (this.loadOnPlay_) { | ||
this.tech_.off('play', this.loadOnPlay_); | ||
} | ||
let updatedPlaylist = this.masterPlaylistLoader_.media(); | ||
|
||
if (!updatedPlaylist) { | ||
|
@@ -1406,6 +1418,10 @@ export class MasterPlaylistController extends videojs.EventTarget { | |
this.masterPlaylistLoader_.dispose(); | ||
this.mainSegmentLoader_.dispose(); | ||
|
||
if (this.loadOnPlay_) { | ||
this.tech_.off('play', this.loadOnPlay_); | ||
} | ||
|
||
['AUDIO', 'SUBTITLES'].forEach((type) => { | ||
const groups = this.mediaTypes_[type].groups; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3718,7 +3718,7 @@ QUnit.test('switching playlists with an outstanding key request aborts request a | |
); | ||
}); | ||
|
||
QUnit.test('does not download segments if preload option set to none', function(assert) { | ||
QUnit.test('does not download anything until play if preload option set to none', function(assert) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test was failing, and didn't really make sense anymore. I modified for the new behavior. |
||
this.player.preload('none'); | ||
this.player.src({ | ||
src: 'master.m3u8', | ||
|
@@ -3728,19 +3728,23 @@ QUnit.test('does not download segments if preload option set to none', function( | |
this.clock.tick(1); | ||
|
||
openMediaSource(this.player, this.clock); | ||
// master | ||
this.standardXHRResponse(this.requests.shift()); | ||
// media | ||
this.standardXHRResponse(this.requests.shift()); | ||
this.clock.tick(10 * 1000); | ||
|
||
this.requests = this.requests.filter(function(request) { | ||
return !(/m3u8$/).test(request.uri); | ||
}); | ||
assert.equal(this.requests.length, 0, 'did not download any segments'); | ||
|
||
// verify stats | ||
assert.equal(this.player.tech_.vhs.stats.bandwidth, 4194304, 'default'); | ||
|
||
this.player.tech_.paused = () => false; | ||
this.player.tech_.trigger('play'); | ||
|
||
// master | ||
this.standardXHRResponse(this.requests.shift()); | ||
|
||
// media | ||
this.standardXHRResponse(this.requests.shift()); | ||
|
||
assert.equal(this.requests.length, 1, 'requested segment'); | ||
}); | ||
|
||
// workaround https://bugzilla.mozilla.org/show_bug.cgi?id=548397 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome