feat: Allow xhr override globally #1059
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is not currently possible to override or add any custom XHR logic at initialization, since the
xhr()
method is not exposed on the tech until the source is set (see) and uses a reference to the originalvideojs.xhr()
.Although it is unadvisable in most cases (as mentioned in the docs), it is still useful to have the ability to do it, and the existing
beforeRequest()
hook is insufficient in many cases.Specific Changes proposed
videojs.Vhs.xhr
function forvideojsXHR
, if it is provided