chore: better worker build #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Dec 10, 2020
| data.iv.byteOffset, | ||
| data.iv.byteLength / 4 | ||
| ); | ||
| self.onmessage = function(event) { |
There was a problem hiding this comment.
We no longer wrap in a function here, instead the code looks exactly as it would running on a web worker, inside of the main script body.
brandonocasey
commented
Dec 10, 2020
| this.messageHandlers = new MessageHandlers(self, event.data.options); | ||
| return; | ||
| } | ||
| self.onmessage = function(event) { |
There was a problem hiding this comment.
again no longer wrapped in a function.
brandonocasey
commented
Dec 10, 2020
| @@ -13,7 +13,7 @@ import { MasterPlaylistController } from '../src/master-playlist-controller'; | |||
| import SourceUpdater from '../src/source-updater'; | |||
| import SyncController from '../src/sync-controller'; | |||
| import TimelineChangeController from '../src/timeline-change-controller'; | |||
| import Decrypter from 'worker!../src/decrypter-worker.worker.js'; | |||
| import Decrypter from 'worker!../src/decrypter-worker.js'; | |||
There was a problem hiding this comment.
slight change since we no longer pre-bundle the worker.
gesinger
reviewed
Jan 5, 2021
brandonocasey
force-pushed
the
chore/better-worker-build
branch
from
80410f6 to
3422c1d
Compare
brandonocasey
force-pushed
the
chore/better-worker-build
branch
from
3422c1d to
0d6f722
Compare
brandonocasey
force-pushed
the
chore/better-worker-build
branch
from
0d6f722 to
f8bf2cf
Compare
gesinger
reviewed
Feb 1, 2021
gesinger
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wrote rollup-plugin-worker-factory for Mux.js so that we could support nodejs workers and browser workers using the same plugin. It has side benefits of: