-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move playback tests to a separate ci run #1028
Changes from all commits
f8ab359
04fd76d
bb4dba6
1a780ec
2ed622a
5be5ab3
f4473ed
8277234
0c540c4
37cb426
39e7c0c
4c79723
6c70ad8
ccb2359
29fce08
3b230c1
1fbffa1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,81 +8,72 @@ jobs: | |
runs-on: ubuntu-latest | ||
# Map a step output to a job output | ||
outputs: | ||
should-skip-job: ${{ steps.skip-check.outputs.should_skip }} | ||
should-skip-job: ${{steps.skip-check.outputs.should_skip}} | ||
steps: | ||
- id: skip-check | ||
uses: fkirc/[email protected] | ||
with: | ||
github_token: ${{ github.token }} | ||
github_token: ${{github.token}} | ||
|
||
ci: | ||
needs: should-skip | ||
if: ${{ needs.should-skip.outputs.should-skip-job != 'true'}} | ||
env: | ||
BROWSER_STACK_USERNAME: ${{ secrets.BROWSER_STACK_USERNAME }} | ||
BROWSER_STACK_ACCESS_KEY: ${{ secrets.BROWSER_STACK_ACCESS_KEY }} | ||
runs-on: ${{ matrix.os }} | ||
if: ${{needs.should-skip.outputs.should-skip-job != 'true'}} | ||
strategy: | ||
# TODO: test IE 11, Legacy Edge, and New Edge on windows-latest | ||
# test Safari on macos-latest | ||
fail-fast: false | ||
matrix: | ||
os: [ubuntu-latest] | ||
|
||
test-type: [unit, playback] | ||
env: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. moved these below matrix, as matrix defines them and it was a bit confusing. |
||
BROWSER_STACK_USERNAME: ${{secrets.BROWSER_STACK_USERNAME}} | ||
BROWSER_STACK_ACCESS_KEY: ${{secrets.BROWSER_STACK_ACCESS_KEY}} | ||
CI_TEST_TYPE: ${{matrix.test-type}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ad CI_TEST_TYPE as an environment variable. |
||
runs-on: ${{matrix.os}} | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: checkout code | ||
uses: actions/checkout@v2 | ||
|
||
- name: Cache dependencies | ||
uses: actions/cache@v2 | ||
with: | ||
path: | | ||
~/.npm | ||
**/node_modules | ||
key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }} | ||
key: ${{runner.os}}-npm-${{hashFiles('**/package-lock.json')}} | ||
restore-keys: | | ||
${{ runner.os }}-npm- | ||
${{ runner.os }}- | ||
${{runner.os}}-npm- | ||
${{runner.os}}- | ||
|
||
- name: Read .nvmrc | ||
- name: read node version from .nvmrc | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add a step name |
||
run: echo ::set-output name=NVMRC::$(cat .nvmrc) | ||
shell: bash | ||
id: nvm | ||
|
||
- name: update apt cache on linux w/o browserstack | ||
run: sudo apt-get update | ||
if: ${{ startsWith(matrix.os, 'ubuntu') && !env.BROWSER_STACK_USERNAME }} | ||
if: ${{startsWith(matrix.os, 'ubuntu') && !env.BROWSER_STACK_USERNAME}} | ||
|
||
- name: Install ffmpeg/pulseaudio for firefox on linux w/o browserstack | ||
- name: install ffmpeg/pulseaudio for firefox on linux w/o browserstack | ||
run: sudo apt-get install ffmpeg pulseaudio | ||
if: ${{ startsWith(matrix.os, 'ubuntu') && !env.BROWSER_STACK_USERNAME }} | ||
if: ${{startsWith(matrix.os, 'ubuntu') && !env.BROWSER_STACK_USERNAME}} | ||
|
||
- name: start pulseaudio for firefox on linux w/o browserstack | ||
run: pulseaudio -D | ||
if: ${{ startsWith(matrix.os, 'ubuntu') && !env.BROWSER_STACK_USERNAME }} | ||
if: ${{startsWith(matrix.os, 'ubuntu') && !env.BROWSER_STACK_USERNAME}} | ||
|
||
- name: Setup node | ||
- name: setup node | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: '${{ steps.nvm.outputs.NVMRC }}' | ||
node-version: '${{steps.nvm.outputs.NVMRC}}' | ||
|
||
# turn off the default setup-node problem watchers... | ||
- run: echo "::remove-matcher owner=eslint-compact::" | ||
- run: echo "::remove-matcher owner=eslint-stylish::" | ||
- run: echo "::remove-matcher owner=tsc::" | ||
|
||
- run: npm i --prefer-offline --no-audit | ||
|
||
# run safari on macos | ||
- name: Run Mac test | ||
run: npm run test -- --browsers Safari | ||
if: ${{ startsWith(matrix.os, 'macos') }} | ||
- name: npm install | ||
run: npm i --prefer-offline --no-audit | ||
|
||
# only run ie 11 on windows | ||
- name: Run Windows test | ||
run: npm run test -- --browsers IE | ||
if: ${{ startsWith(matrix.os, 'windows') }} | ||
|
||
# run chrome/firefox or browserstack in linux | ||
- name: Run linux test | ||
- name: run npm test | ||
uses: GabrielBB/xvfb-action@v1 | ||
with: | ||
run: npm test | ||
if: ${{ startsWith(matrix.os, 'ubuntu') }} | ||
|
||
run: npm run test | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When we test on other operating systems we can worry about all the other code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the spacing throughout this file, some had extra spaces, and others did not.