fix: convert non-latin characters in IE #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
Jul 17, 2018
src/util/string.js
Outdated
| @@ -0,0 +1,2 @@ | |||
| export const uintToString = (uintArray) => | |||
There was a problem hiding this comment.
Minor, but this function is doing a bit more than just converting the typed array to a string. We may want to either rename the function or just call decodeURIComponent and escape within vtt-segment-loader.
test/util/string.test.js
Outdated
| import QUnit from 'qunit'; | ||
| import { uintToString } from '../../src/util/string'; | ||
|
|
||
| QUnit.module('uintToString'); |
There was a problem hiding this comment.
Minor, but may want a blank line here
gesinger
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes videojs/video.js#5070
Specific Changes proposed
Fixes the fallback text decoder. (https://stackoverflow.com/a/17192845)
Requirements Checklist