Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese subtitle is broken in IE 11 #5070

Closed
zironycho opened this issue Apr 3, 2018 · 6 comments · Fixed by videojs/http-streaming#157
Closed

Japanese subtitle is broken in IE 11 #5070

zironycho opened this issue Apr 3, 2018 · 6 comments · Fixed by videojs/http-streaming#157
Assignees

Comments

@zironycho
Copy link

zironycho commented Apr 3, 2018

Description

Japanese subtitle is broken in IE 11
used demo url
captured

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. open url on IE 11.
  2. change cc to Japanese

Results

Expected

display Japanese subtitle

Actual

broken subtitle text

Error output

captured

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

It is just official demo page from videojs-contrib-hls

browsers

IE 11.

OSes

Windows 10 Home

plugins

videojs-contrib-hls

@gkatsev
Copy link
Member

gkatsev commented Apr 4, 2018

That's really interesting. The first thing I noticed is that the VTT file wasn't being served with the correct mimetype. I tried changing the mimetype using the Charles proxy but it was still not doing the right thing. We should probably still change the mimetype.
Also, adding the file as a <track> element seems to work just fine.
This is probably related to us defaulting a "string decoder" when a utf8 TextDecoder isn't available: https://github.com/videojs/videojs-contrib-hls/blob/a3ecfd0b346c7a55f198e772dc07ffd4b212a7e2/src/vtt-segment-loader.js#L314-L323
It should work fine if a TextDecoder polyfill is included on the page, we don't ship one by default because it often isn't needed and it's a pretty large piece of code otherwise.

@zironycho
Copy link
Author

@gkatsev ❤️ Thank you for response and answer.
I will try that you suggested !!

@gkatsev
Copy link
Member

gkatsev commented Jun 7, 2018

After investigating it some more, we think this may be because we're downloading the text as arraybuffers in VHS/hls. @forbesjo is going to look into if we can just download it as just text, which may improve this behavior.

@gkatsev
Copy link
Member

gkatsev commented Jun 18, 2018

This is being worked on in VHS: videojs/http-streaming#105

@forbesjo
Copy link
Contributor

The fix has been deployed in VHS, it should be picked up by video.js 7 some time soon

@gkatsev
Copy link
Member

gkatsev commented Jul 25, 2018

This is fixed in @vidoejs/http-streaming 1.2.1 and it's in Video.js as of commit 7b6aa5c, it'll be in the next release.

@gkatsev gkatsev closed this as completed Jul 25, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants