fix(live): cue end time not finite #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1411 +/- ##
=======================================
Coverage 85.56% 85.56%
=======================================
Files 41 41
Lines 10146 10147 +1
Branches 2352 2353 +1
=======================================
+ Hits 8681 8682 +1
Misses 1465 1465
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
misteroneill
approved these changes
Jul 25, 2023
| @@ -234,7 +234,8 @@ export const addMetadata = ({ | |||
| // Map each cue group's endTime to the next group's startTime | |||
| sortedStartTimes.forEach((startTime, idx) => { | |||
| const cueGroup = cuesGroupedByStartTime[startTime]; | |||
| const nextTime = Number(sortedStartTimes[idx + 1]) || videoDuration; | |||
There was a problem hiding this comment.
Sorry for commenting on merged PR, but maybe we should consider endTime= startTime instead of 0 in this case?
There was a problem hiding this comment.
Good catch. Just saw a link to this from another issue. Will put up a quick PR for that fix, I agree start time is more appropriate.
There was a problem hiding this comment.
Sry to comment this, but when the endTime is set to the starttime or "0".... the cue doesn't get active anymore.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating metadata cues, the last cue uses the videoDuration as the end time, in live playback this is
Infinityand throws an error.Specific Changes proposed
Add an
isFinitecheck to the duration, if it's not finite we use 0 instead.Requirements Checklist