-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: In-manifest VTT iOS MSE issue #1360
Fix: In-manifest VTT iOS MSE issue #1360
Conversation
…d for any reasons.
… we do not have it loaded
Codecov Report
@@ Coverage Diff @@
## main #1360 +/- ##
==========================================
+ Coverage 86.01% 86.03% +0.01%
==========================================
Files 40 40
Lines 9842 9855 +13
Branches 2294 2295 +1
==========================================
+ Hits 8466 8479 +13
Misses 1376 1376
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
.then( | ||
() => this.segmentRequestFinished_(error, simpleSegment, result), | ||
() => this.stopForError({ message: 'Error loading vtt.js' }) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tidy-up job here 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!
Description
We have a bug with default options setup for HLS in-manifest VTT in chrome iOS (and I assume other non-safari Webkit-based iOS browsers). The problem is that we do not load
vtt.js
, but we useVHS
to handle playback.vtt-segment-loader
implicitly depends onwindow.WebVTT.Parser
. Sincevtt.js
is not loaded -window.WebVTT
isundefined
. It means that we are not able to parse received VTT cues.Specific Changes proposed
vtt.js
invtt-segment-loader
if we do not have it loaded. (eg: forceoverrideNative
option case).Requirements Checklist