fix: do not request manifests until play when preload is none #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
changed the title
brandonocasey
changed the title
brandonocasey
commented
Feb 3, 2021
| @@ -3718,7 +3718,7 @@ QUnit.test('switching playlists with an outstanding key request aborts request a | |||
| ); | |||
| }); | |||
|
|
|||
| QUnit.test('does not download segments if preload option set to none', function(assert) { | |||
| QUnit.test('does not download anything until play if preload option set to none', function(assert) { | |||
There was a problem hiding this comment.
This test was failing, and didn't really make sense anymore. I modified for the new behavior.
|
Great. I haven't tested it yet. But this probably also prevents a scenario with experimentalBufferBasedABR where the buffer check is constantly repeated at a short interval while the player is not 'loaded', see #1041 |
gkatsev
approved these changes
Feb 9, 2021
| @@ -85,6 +88,13 @@ <h3>Options</h3> | |||
| <input id=override-native type="checkbox" checked> | |||
| Override Native (reloads player) | |||
| </label> | |||
| <label> | |||
| @@ -279,7 +279,16 @@ export class MasterPlaylistController extends videojs.EventTarget { | |||
| this.logger_ = logger('MPC'); | |||
|
|
|||
| this.triggeredFmp4Usage = false; | |||
| this.masterPlaylistLoader_.load(); | |||
| if (this.tech_.preload() === 'none') { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't do a very good job respecting
preload=noneon the video element because even with preload=none we still download the manifests and potentially waste bandwidth with videos that never get played. We should prevent that when preload is set tonone.