Skip to content

Commit

Permalink
make it a log line
Browse files Browse the repository at this point in the history
  • Loading branch information
brandonocasey committed Jan 11, 2021
1 parent 9deea5e commit c5b8dc5
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions src/util/codecs.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ import {
parseCodecs,
codecsFromDefault
} from '@videojs/vhs-utils/es/codecs.js';
import logger from './logger.js';

const logFn = logger('CodecUtils');

/**
* Returns a set of codec strings parsed from the playlist or the default
Expand Down Expand Up @@ -59,15 +62,18 @@ export const unwrapCodecList = function(codecList) {
const codecs = {};

codecList.forEach(({mediaType, type, details}) => {
codecs[mediaType] = codecs[mediaType] || [];
codecs[mediaType].push(translateLegacyCodec(`${type}${details}`));
});

// TODO: log a warning, something like:
// multiple ${mediaType} codecs found for playlist, leaving it to
// mux.js to probe content for codecs.
if (codecs.hasOwnProperty(mediaType)) {
Object.keys(codecs).forEach(function(mediaType) {
if (codecs[mediaType].length > 1) {
logFn(`multiple ${mediaType} codecs found as attributes: ${codecs[mediaType].join(', ')}. Setting playlist codecs to null so that we wait for mux.js to probe segments for real codecs.`);
codecs[mediaType] = null;
return;
}
codecs[mediaType] = translateLegacyCodec(`${type}${details}`);

codecs[mediaType] = codecs[mediaType][0];
});

return codecs;
Expand Down

0 comments on commit c5b8dc5

Please sign in to comment.