Skip to content

Commit

Permalink
fix: Support aac data with or without id3 tags by using [email protected] (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
brandonocasey authored Jul 10, 2020
1 parent 7711b26 commit 9c742ce
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"global": "^4.3.2",
"m3u8-parser": "4.4.2",
"mpd-parser": "0.10.1",
"mux.js": "5.6.5",
"mux.js": "5.6.6",
"video.js": "^6 || ^7"
},
"devDependencies": {
Expand Down
8 changes: 4 additions & 4 deletions test/media-segment-request.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ QUnit.test('aac with id3 will make it to the transmuxer', function(assert) {
this.options.doneFn = () => {
assert.deepEqual(this.calls, {
data: 1,
trackInfo: 48,
trackInfo: 1,
progress: 1,
timingInfo: 2,
captions: 0,
Expand All @@ -272,15 +272,15 @@ QUnit.test('aac with id3 will make it to the transmuxer', function(assert) {
this.standardXHRResponse(this.requests[0], aacWithId3Segment());
});

QUnit.skip('aac without id3 will make it to the transmuxer', function(assert) {
QUnit.test('aac without id3 will make it to the transmuxer', function(assert) {
const done = assert.async();

this.options.segment.transmuxer = this.createTransmuxer();
this.options.segment.resolvedUri = 'foo.aac';
this.options.doneFn = () => {
assert.deepEqual(this.calls, {
data: 1,
trackInfo: 47,
trackInfo: 1,
progress: 1,
timingInfo: 2,
captions: 0,
Expand Down Expand Up @@ -440,7 +440,7 @@ QUnit.test('aac with id3 will make it to the partial transmuxer', function(asser
this.standardXHRResponse(this.requests[0], aacWithId3Segment());
});

QUnit.skip('aac without id3 will make it to the partial transmuxer', function(assert) {
QUnit.test('aac without id3 will make it to the partial transmuxer', function(assert) {
const done = assert.async();

this.options.segment.transmuxer = this.createTransmuxer(true);
Expand Down

0 comments on commit 9c742ce

Please sign in to comment.