provider: add a AWS Elemental MediaConvert provider #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 78.62% 78.36% -0.26%
==========================================
Files 29 31 +2
Lines 2914 3310 +396
==========================================
+ Hits 2291 2594 +303
- Misses 372 446 +74
- Partials 251 270 +19
Continue to review full report at Codecov.
|
fsouza
reviewed
Jul 13, 2019
We don't want this code to do anything inexpected. By checking these values separately, if a config is incomplete and a key was provided but no secret (or the other way around) the static creds logic is not run and when run, nothing will error and default creds may be used unexpectedly. Let's make sure that if anything was provided for key or secret, we run the static credentials logic.
fsouza
approved these changes
Jul 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.aws.amazon.com/mediaconvert/latest/apireference/resources.html
Closes #194