Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build errors #207

Merged
merged 1 commit into from
Apr 2, 2019
Merged

fix build errors #207

merged 1 commit into from
Apr 2, 2019

Conversation

my3
Copy link
Contributor

@my3 my3 commented Apr 2, 2019

@fsouza
Copy link
Collaborator

fsouza commented Apr 2, 2019

@my3 thanks for fixing this!

@codecov-io
Copy link

codecov-io commented Apr 2, 2019

Codecov Report

Merging #207 into master will not change coverage.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   78.62%   78.62%           
=======================================
  Files          29       29           
  Lines        2914     2914           
=======================================
  Hits         2291     2291           
  Misses        372      372           
  Partials      251      251
Impacted Files Coverage Δ
provider/bitmovin/bitmovin.go 65.14% <0%> (ø) ⬆️
provider/zencoder/zencoder.go 82.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a435d...4544927. Read the comment docs.

@fsouza fsouza merged commit f1fda45 into video-dev:master Apr 2, 2019
@my3 my3 deleted the fix_make_test branch April 2, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants