Prevent Widevine access request on "encrypted" w/o configured license url #6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
changed the title
robwalch
added a commit
that referenced
this pull request
Jan 10, 2025
Changes picked from #6644 and #6948 with changes for feedback from @cjpillsbury
robwalch
added a commit
that referenced
this pull request
Jan 10, 2025
…for playback (#6946) cherry-picked d602e36 Author: Christian Pillsbury <[email protected]> (+1 squashed commit) Squashed commits: [4522cb0] Only use selected key-system in EME "mediaencrypted" event handler Changes picked from #6644 and #6948 with changes for feedback from @cjpillsbury
3 tasks
robwalch
added a commit
that referenced
this pull request
Jan 10, 2025
…for playback (#6946) cherry-picked d602e36 Author: Christian Pillsbury <[email protected]> (+1 squashed commit) Squashed commits: [4522cb0] Only use selected key-system in EME "mediaencrypted" event handler Changes picked from #6644 and #6948 with changes for feedback from @cjpillsbury
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Why is this Pull Request needed?
Prevents the browser from requesting access to the Widevine key-system when the media contains Widevine keys, but the player is not configured to requests a license (only configured for Playready).
Are there any points in the code the reviewer needs to double check?
onMediaEncryptedlogic for the selected key-system is based on the premise that the access request(s) keys and not the result of the first passing access request. This may need some work when the initData contains multiple keys for different key-systems.Resolves issues:
Resolved #6005
Checklist