Fix reduceMaxBufferLength with under-reported bitrate
#6539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duration resulting in buffer full error Resolves #6535
robwalch
deleted the
bugfix/patch-reduce-max-buffer-under-reported-bitrate
branch
robwalch
added a commit
that referenced
this pull request
Jul 3, 2024
* patch/v1.5.x: Make sure `reduceMaxBufferLength` can reach a min length of fragment duration resulting in buffer full error (#6539) Fix parsing of multiple codecs when converting from AVC1 to AVCOTI Fix XSS vulnerability by validating user input stream URL.
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Make sure
reduceMaxBufferLengthcan reach a min length of fragment duration resulting in buffer full error.Why is this Pull Request needed?
With under-reported bitrate the player may try to reload media that cannot be appended after reducing max buffer length close to but not all the way to the needed minimum.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Resolves #6535
Checklist