Add liveSyncOnStallIncrease config option #6455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
add a new configuration option
liveSyncOnStallIncrease
to replace the constant currently used byLatencyController
:hls.js/src/controller/latency-controller.ts
Line 63 in 134b79b
Why is this Pull Request needed?
Currently each time the player encounters a stall,
targetLatency
is incremented by 1 second, seehls.js/src/controller/latency-controller.ts
Lines 63 to 69 in 134b79b
This PR replaces local
const liveSyncOnStallIncrease = 1.0
with a value coming from hls.js config, as suggested here.Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist