Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Patch for light player exception with audio groups #6342

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

iamboorrito
Copy link
Collaborator

@iamboorrito iamboorrito commented Apr 10, 2024

This PR will...

Don't look through audio groups if environment USE_ALT_AUDIO is false

setup.js: Update entries 10 -> 12 to add tests to light build

Why is this Pull Request needed?

Fix light build as described in #6316

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #6316

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

…alse

Update entries 10 -> 12 to add tests to light build
@iamboorrito iamboorrito requested a review from robwalch April 10, 2024 21:32
@robwalch robwalch changed the title <#6316> Patch for light player exception with audio groups Bugfix: Patch for light player exception with audio groups Apr 10, 2024
@iamboorrito iamboorrito added this to the 1.5.8 milestone Apr 10, 2024
@robwalch robwalch merged commit e0fbd41 into master Apr 10, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/fixLightBuild branch April 10, 2024 22:11
iamboorrito added a commit that referenced this pull request Apr 10, 2024
* Don't look through audio groups if environment __USE_ALT_AUDIO__ is false
* Update entries 10 -> 13 to add tests to light build
robwalch added a commit that referenced this pull request Apr 11, 2024
* patch/v1.5.x:
  Bugfix: Patch for light player exception with audio groups (#6342)
  Do not use "levelCodec" to instantiate SourceBuffer when multiple audio codec strings are present in the Multivariant Playlist variant CODECS attribute with muxed content (#6341)
  Bugfix: preferManagedMediaSource:false when MSE is not present  (#6338)
  Determine canSkip based on age of last playlist request (#6300)
  API.md update removeLevel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some manifest files crash player when using hls.light.min.js with undefined (hasAutoSelect) error
2 participants