Fix compatibility of ManagedMediaSource implementation with Edge 18 #6246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
bugfix/mms-edge-18
branch
from
c2b5f39 to
75cf030
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix compatibility of ManagedMediaSource implementation with Edge 18. Gate all ManagedMediaSource logic, including appending child source element by the presence of the ManagedMediaSource API.
Why is this Pull Request needed?
SourceBuffers get stuck in "updating" state assigning MediaSource to a child
sourceelement of HTMLMediaElement in Edge 18.Are there any points in the code the reviewer needs to double check?
Resolves issues:
Fixes #6243
Checklist