Fix esds box parsing for usac audio #6019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
feature/esds-parsing
branch
from
af8402a to
c5326be
Compare
robwalch
commented
Dec 8, 2023
| } | ||
| if (flags & 0x40) { | ||
| i += esdsBox[i++]; // skip URL | ||
| } |
There was a problem hiding this comment.
Intentionally ignoring the OCR esid flag as this was previously reserved and expected to be ignored. There are assets in the wild with malformed esds atoms where this is signaled but should be ignored.
If you have a valid asset where this is present, please file an issue using the Bug Report Template as part of your issue, making sure to include the test stream/page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix esds box parsing for usac audio
Why is this Pull Request needed?
Corrects codec string parsing of init segments with AAC audio:
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Prevents "mp4a.40.5" from being used in place of the correct audio object type, and reduces the change of encountering this log message:
Checklist