Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDR/SDR VIDEO-RANGE selection and priority #6007

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Nov 30, 2023

This PR will...

  • Add videoPreference config option for HDR/SDR VIDEO-RANGE selection preference and priority.
  • Query high dynamic-range capability and use result to select from allowedVideoRanges when specified.
  • Fix an exception on platforms where MediaCapabilities is undefined

Why is this Pull Request needed?

These settings determine whether HDR video should be selected before SDR video. Which VIDEO-RANGE values are allowed, and in what order of priority can also be specified.

Are there any points in the code the reviewer needs to double check?

By default, when videoPreference is undefined, SDR will always preferred for maximum backwards compatibility. To enable HDR selection using the media query results without changing allowedVideoRanges, include an empty videoPreference object in the player config at setup.

Resolves issues:

Resolves #2489

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.0 milestone Nov 30, 2023
@robwalch robwalch force-pushed the feature/video-range branch 2 times, most recently from f9c8c95 to 0bb9630 Compare November 30, 2023 01:14
@robwalch robwalch force-pushed the feature/video-range branch from 0bb9630 to 1aac9c9 Compare November 30, 2023 20:40
@robwalch robwalch force-pushed the feature/video-range branch from 355e5d4 to d0c0aa6 Compare December 1, 2023 00:26
@robwalch robwalch merged commit f53fed3 into master Dec 4, 2023
15 of 16 checks passed
@robwalch robwalch deleted the feature/video-range branch December 4, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VIDEO-RANGE attribute support (HDR/SDR selection)
2 participants