Do not exit from stall detection when playhead is at or past end of buffer #5779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Allow stalls to be reported when playhead at the edge or outside a buffered range.
Why is this Pull Request needed?
Playback doesn't always stall inside a buffered range. Typically it stalls at the end of one.
Are there any points in the code the reviewer needs to double check?
The code being moved is to prevent stalls from being reported and stall nudges from being performed while seeking. The issue was that some clients resolve seeking before media is buffered.
Resolves issues:
Resolves part of #5759
Checklist