Handle #EXT-X-ENDLIST appended to live playlist without new segment

[robwalch]

This PR will...

Treat LevelDetails as updated when #EXT-X-ENDLIST is appended to live playlist without new segment. Mark the corresponding segment in the previous details object with endList = true so that the fragment-tracker can add it to endListFragments.

Why is this Pull Request needed?

endListFragments is used to determine that everything from the playhead to the end of the playlist has been buffered so that the MediaSource and SourceBuffer(s) can be marked as ended.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #5777

Checklist

• changes have been done against master branch, and PR does not conflict
• new unit / functional tests have been added (whenever applicable)
• API or design changes are documented in API.md

[robwalch]

cc @MosheMaorKaltura

[OrenMe]

LGTM! We also have clear repro so will be tested before to make sure it solves the issue

[semarche-kaltura]

The issue #5777 still reproduces with bugfix/live-append-only-endlist branch.
Short investigation shows that when parseLevelPlaylist handles ENDLIST and oldFrag.endList = true; method detectPartialFragments doesn't executes (endListFragments object keeps empty), so isEndListAppended always returns false.

[robwalch]

The issue #5777 still reproduces with bugfix/live-append-only-endlist branch.
Short investigation shows that when parseLevelPlaylist handles ENDLIST and oldFrag.endList = true; method detectPartialFragments doesn't executes (endListFragments object keeps empty), so isEndListAppended always returns false.

If the last segment is appended before the ENDLIST is published and loaded that is definitely possible.

[robwalch]

@semarche-kaltura, 89c648f 9c9e79e will force detectPartialFragments when the playlist updates with ENDLIST now.

It might be worth noting that when the stream does end, because it has a sliding window, it cannot behave as a VOD in the current session since there are no segments available at 0.

[semarche-kaltura]

With 89c648f playback works as expected! 👍

[semarche-kaltura]

@robwalch we would want have the changes as "patch" but I don't have permissions for open a PR against the "patch/v1.4.x" branch.

[robwalch]

@robwalch we would want have the changes as "patch" but I don't have permissions for open a PR against the "patch/v1.4.x" branch.

You can make a commit off of a fork of that branch and then open a PR. If GitHub then does not let you change the target branch of your PR, @OrenMe or I can.

[semarche-kaltura]

@robwalch I've opened PR from forked repo (base "patch/v1.4.x" branch + cherrypicked commits from "bugfix/live-append-only-endlist" branch) into "patch/v1.4.x" branch, check if everything made correct. Thanks.