Use last discontinuity bounds when aligning playlists on PDT #5681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
commented
Jul 19, 2023
robwalch
force-pushed
the
bugfix/align-pdt-disco-bounds
branch
2 times, most recently
from
02690de to
30187bc
Compare
Realign audio playlist when waiting for initPTS Deprecate redundant align PDT method
robwalch
force-pushed
the
bugfix/align-pdt-disco-bounds
branch
from
30187bc to
3f9cbf4
Compare
|
Adding past contributors for feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Use last discontinuity bounds when aligning playlists on PDT.
Realigns audio playlist when waiting for initPTS, and removes redundant alignPDT method.
Why is this Pull Request needed?
Ensures proper alignment of live streams which do not carry contiguous PDT values across discontinuities.
When the middle reference fragments from the audio and main playlists do not share the same discontinuity sequence, this method could fail to align the playlists correctly because of differences in the PDT between segments.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist