Make loader context nullable and cleanup loader cleanup #5552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvnam96
reviewed
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Make loader context nullable and cleanup loader cleanup
Why is this Pull Request needed?
contextis undefined beforeload()is called. Making it nullable and clearing it on destroy makes it easier to deal with loader usage after the end of its lifecycle.Are there any points in the code the reviewer needs to double check?
Do apps currently use these loader properties after loaders are destroyed (
contextorstats)? At the very least we should clear(xhr|fetch)Setupcallbacks on destroy to remove any references hoisted into the scope of these functions.Resolves issues:
Followup to #5494