Only allow large gaps to be skipped if start gap or all fragments in range are partial #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtoczko
previously approved these changes
Apr 1, 2023
robwalch
commented
Apr 1, 2023
…range are partial Fixes #5360
robwalch
force-pushed
the
bugfix/large-gap-skip-check
branch
from
5096486 to
ef156b7
Compare
robwalch
force-pushed
the
bugfix/large-gap-skip-check
branch
from
ef156b7 to
c95b0f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Only allow large gaps to be skipped if start gap or all fragments in range are partial
Why is this Pull Request needed?
Prevents large gap jumps introduced in v1.4.0-beta with the exception of start gaps and spans containing tracked fragments with GAP tags.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Fixes #5360
Checklist