Clear subtitle-stream-controller buffered list on detach #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Display subtitles that have been loaded before detaching and reattaching the media element (or using
recoverMediaError).Why is this Pull Request needed?
The subtitle-stream-controller keeps track of which subtitle segments have been loaded using
tracksBuffered. This data must be cleared on detach since the cues containing the loaded subtitles are removed at the same time. If we do not do this then subtitles that have been loaded previously will not be reloaded or displayed after reattaching the media element (#5353).Are there any points in the code the reviewer needs to double check?
Resolves issues:
Fixes #5353
Checklist