Handle invalid signed "tfdt" decode time values #5333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
bugfix/wrapped-track-fragment-decode-time
branch
from
0142925
to
5135cf9
Compare
robwalch
force-pushed
the
bugfix/wrapped-track-fragment-decode-time
branch
from
8eaf3a8
to
2726f52
Compare
robwalch
force-pushed
the
bugfix/wrapped-track-fragment-decode-time
branch
from
0fece0a
to
6c493ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Live to VOD streams from some vendors contain invalid CMAF tfdt (track fragment decode time). We suspect they tried writing a negative value to what is defines as an unsigned 64-bit integer. Assume that is the case when a value above 63-bit is found, and ignore it. Continuing to parse the remaining tfdt atoms if present, or returning null should ensure that the player uses a valid value or fallback to playlist time/passthrough, and prevents the invalid media timecode from shifting the playlist it is found in.
Why is this Pull Request needed?
If the first fmp4 segment loaded for a playlist has an invalid tfdt base media time the
initPTSis assigned a bad value and the playlist is shifted. This can cause CMAF audio and video to be completely de-synced (the segments in the playlist affected can no longer be found).Resolves issues:
Resolves #5303