Support partial RENDITION-REPORT URI matches fallback #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
commented
Jan 21, 2023
5 tasks
robwalch
added a commit
that referenced
this pull request
Jan 26, 2023
* Support partial RENDITION-REPORT URI matches fallback Fixes #5174 * Update find Rendition Report match comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
When performing a switch, if no exact URI match to a RENDITION-REPORT is found, use the last RENDITION-REPORT URI that matches the target Playlist URI from start to Rendition URI length.
Why is this Pull Request needed?
Switches will be performed using RENDITION-REPORT Delivery Directives when Media Playlist URI has a query string, and the RENDITION-REPORT URI does not.
Are there any points in the code the reviewer needs to double check?
It could be worth considering simply using the current Playlist's last msn and part index when a matching RENDITION-REPORT cannot be found. A failed attempt would fall back to a request without Delivery Directives. However, the player should avoid making requests that could cause errors to get cached on edge servers.
Resolves issues:
Fixes #5174
Checklist