Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for supporting more audio codecs #3930

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

softworkz
Copy link
Contributor

For a start, it's primarily about getting rid of the IsAAC property where true means AAC and false means MP3/2/1

@robwalch
Copy link
Collaborator

See #1102. Maybe some of that work could be brought forward into these changes.

@robwalch robwalch self-requested a review May 28, 2021 15:18
@softworkz
Copy link
Contributor Author

See #1102. Maybe some of that work could be brought forward into these changes.

Yes, I know that patch and I've actually been experimenting with that one. This PR is about laying the baseline for this..

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the Stale label Apr 16, 2022
@stale
Copy link

stale bot commented Apr 19, 2022

This issue has been automatically closed because it has not had recent activity. If this issue is still valid, please ping a maintainer and ask them to label it accordingly.

@stale stale bot closed this Apr 19, 2022
@robwalch robwalch removed the Stale label Apr 19, 2022
@robwalch robwalch reopened this Apr 19, 2022
@softworkz
Copy link
Contributor Author

@robwalch - Thanks for re-opening. I had some other focus areas recently, but I'm still interested in moving this forward.

@mataspetrikas
Copy link

out of curiosity, would this PR change open the door for a potential FLAC support in the future?

@softworkz
Copy link
Contributor Author

out of curiosity, would this PR change open the door for a potential FLAC support in the future?

Yes.

@nickcarterney
Copy link

nickcarterney commented Jun 1, 2022

:D Have anyone solves those conflicts? I'm waiting for this commit

@robwalch robwalch added this to the 1.2.0 milestone Jun 1, 2022
@robwalch robwalch merged commit 1dd10d0 into video-dev:master Jun 1, 2022
@softworkz
Copy link
Contributor Author

Oh, that came unexpected...
Better late than never, though. Thanks a lot for merging!

@robwalch robwalch mentioned this pull request Jan 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants