Merge pull request #2391 from video-dev/remove-slice-pollyfill

remove slice pollyfill

src/crypt/aes-decryptor.ts

@@ -1,9 +1,11 @@
+import { sliceUint8 } from '../utils/typed-array';
+
 // PKCS7
 export function removePadding (buffer) {
   const outputBytes = buffer.byteLength;
   const paddingBytes = outputBytes && (new DataView(buffer)).getUint8(outputBytes - 1);
   if (paddingBytes) {
-    return buffer.slice(0, outputBytes - paddingBytes);
+    return sliceUint8(buffer, 0, outputBytes - paddingBytes);
   } else {
     return buffer;
   }

src/crypt/decrypter.ts

@@ -3,6 +3,7 @@ import FastAESKey from './fast-aes-key';
 import AESDecryptor, { removePadding } from './aes-decryptor';
 import { logger } from '../utils/logger';
 import { appendUint8Array } from '../utils/mp4-tools';
+import { sliceUint8 } from '../utils/typed-array';
 
 const CHUNK_SIZE = 16; // 16 bytes, 128 bits
 
@@ -95,7 +96,7 @@ export default class Decrypter {
     const result = currentResult;
 
     this.currentResult = softwareDecrypter.decrypt(currentChunk.buffer, 0, iv);
-    this.currentIV = currentChunk.slice(-16).buffer;
+    this.currentIV = sliceUint8(currentChunk, -16).buffer;
 
     if (!result) {
       return null;
@@ -134,8 +135,8 @@ export default class Decrypter {
     let currentChunk = data;
     const splitPoint = data.length - (data.length % CHUNK_SIZE);
     if (splitPoint !== data.length) {
-      currentChunk = data.slice(0, splitPoint);
-      this.remainderData = data.slice(splitPoint);
+      currentChunk = sliceUint8(data, 0, splitPoint);
+      this.remainderData = sliceUint8(data, splitPoint);
     }
     return currentChunk;
   }

src/demux/base-audio-demuxer.ts

@@ -2,6 +2,7 @@ import ID3 from '../demux/id3';
 import { DemuxerResult, Demuxer, DemuxedTrack, DemuxedAudioTrack } from '../types/demuxer';
 import { dummyTrack } from './dummy-demuxed-track';
 import { appendUint8Array } from '../utils/mp4-tools';
+import { sliceUint8 } from '../utils/typed-array';
 
 class BaseAudioDemuxer implements Demuxer {
   protected _audioTrack!: DemuxedAudioTrack;
@@ -82,7 +83,7 @@ class BaseAudioDemuxer implements Demuxer {
         offset++;
       }
       if (offset === length && lastDataIndex !== length) {
-        const partialData = data.slice(lastDataIndex);
+        const partialData = sliceUint8(data, lastDataIndex);
         this.cachedData = appendUint8Array(this.cachedData, partialData);
       }
     }

src/demux/transmuxer-worker.ts

@@ -1,5 +1,3 @@
-import '../polyfills/runtime-polyfills';
-
 import Transmuxer, { isPromise } from '../demux/transmuxer';
 import Event from '../events';
 import { enableLogs } from '../utils/logger';

src/demux/tsdemuxer.ts

@@ -18,6 +18,7 @@ import { logger } from '../utils/logger';
 import { ErrorTypes, ErrorDetails } from '../errors';
 import { DemuxedAvcTrack, DemuxedAudioTrack, DemuxedTrack, Demuxer, DemuxerResult } from '../types/demuxer';
 import { appendUint8Array } from '../utils/mp4-tools';
+import { sliceUint8 } from '../utils/typed-array';
 
 // We are using fixed track IDs for driving the MP4 remuxer
 // instead of following the TS PIDs.
@@ -208,7 +209,7 @@ class TSDemuxer implements Demuxer {
       };
     }
     len -= (len + syncOffset) % 188;
-    this.remainderData = data.slice(len);
+    this.remainderData = sliceUint8(data, len);
 
     // loop through TS packets
     for (start = syncOffset; start < len; start += 188) {

src/hls.ts

@@ -1,4 +1,3 @@
-import './polyfills/runtime-polyfills';
 import * as URLToolkit from 'url-toolkit';
 
 import {

src/utils/chunker.ts

@@ -1,4 +1,5 @@
 import { appendUint8Array } from './mp4-tools';
+import { sliceUint8 } from './typed-array';
 
 export default class Chunker {
   private chunkSize: number;
@@ -28,10 +29,10 @@ export default class Chunker {
       let offset = 0;
       const len = temp.length;
       while (offset < (len - chunkSize)) {
-        result.push(temp.slice(offset, offset + chunkSize));
+        result.push(sliceUint8(temp, offset, offset + chunkSize));
         offset += chunkSize;
       }
-      this.cache = temp.slice(offset);
+      this.cache = sliceUint8(temp, offset);
     } else {
       result.push(temp);
     }

src/utils/mp4-tools.ts

@@ -1,3 +1,5 @@
+import { sliceUint8 } from './typed-array';
+
 // Todo: Optimize by using loops instead of array methods
 const UINT32_MAX = Math.pow(2, 32) - 1;
 
@@ -445,8 +447,8 @@ export function segmentValidRange (data: Uint8Array): SegmentedRange {
   }
   const last = moofs[moofs.length - 1];
   // Offset by 8 bytes; findBox offsets the start by as much
-  segmentedRange.valid = data.slice(0, last.start - 8);
-  segmentedRange.remainder = data.slice(last.start - 8);
+  segmentedRange.valid = sliceUint8(data, 0, last.start - 8);
+  segmentedRange.remainder = sliceUint8(data, last.start - 8);
   return segmentedRange;
 }
 

src/utils/typed-array.ts

@@ -0,0 +1,5 @@
+export function sliceUint8 (array: Uint8Array, start?: number, end?: number): Uint8Array {
+  return Uint8Array.prototype.slice
+    ? array.slice(start, end)
+    : new Uint8Array(Array.prototype.slice.call(array, start, end));
+}