Merge pull request #6022 from video-dev/bugfix/is-safe-integer-polyfill

Add polyfill for isSafeInteger
video-dev · Dec 7, 2023 · 094db5e · 094db5e
2 parents 5e972ca + e0d2692
commit 094db5e
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/build-config.js b/build-config.js
@@ -147,6 +147,14 @@ const babelTsWithPresetEnvTargets = ({ targets, stripConsole }) =>
                 'isFiniteNumber',
                 path.resolve('src/polyfills/number'),
               );
+            } else if (
+              espath.get('callee').matchesPattern('Number.isSafeInteger')
+            ) {
+              espath.node.callee = importHelper.addNamed(
+                espath,
+                'isSafeInteger',
+                path.resolve('src/polyfills/number'),
+              );
             } else if (
               espath.get('callee').matchesPattern('Number.MAX_SAFE_INTEGER')
             ) {

diff --git a/src/polyfills/number.ts b/src/polyfills/number.ts
@@ -1,7 +1,15 @@
+// https://caniuse.com/mdn-javascript_builtins_number_isfinite
 export const isFiniteNumber =
   Number.isFinite ||
   function (value) {
     return typeof value === 'number' && isFinite(value);
   };
 
+// https://caniuse.com/mdn-javascript_builtins_number_issafeinteger
+export const isSafeInteger =
+  Number.isSafeInteger ||
+  function (value) {
+    return typeof value === 'number' && Math.abs(value) <= MAX_SAFE_INTEGER;
+  };
+
 export const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || 9007199254740991;
diff --git a/src/utils/mp4-tools.ts b/src/utils/mp4-tools.ts
@@ -548,7 +548,7 @@ export function getStartDTS(
             // convert base time to seconds
             const startTime = baseTime / scale;
             if (
-              isFinite(startTime) &&
+              Number.isFinite(startTime) &&
               (result === null || startTime < result)
             ) {
               return startTime;
@@ -560,7 +560,7 @@ export function getStartDTS(
       );
       if (
         start !== null &&
-        isFinite(start) &&
+        Number.isFinite(start) &&
         (result === null || start < result)
       ) {
         return start;