Uses msvc for windows test actions #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @vidalt , it's better to use native compiler such as MSVC instead of MinGW for windows, as MinGW project is much more bug prone than GCC on linux.
Repo https://github.com/ilammy/msvc-dev-cmd seems to be trustworthy, and any issue in tests will not cause any security issue.. but it's also possible for @vidalt to fork it and we use this forked link here... but important updates may be missed, so I think it's fine to just use ilammy/msvc-dev-cmd
Fixes #33
Closes #33