Skip to content

Commit

Permalink
Renovate the "DNS Programming Cores" panel
Browse files Browse the repository at this point in the history
Sum by service_kind instead of using it for filtering. The filtering can
still be done by selecting the series in the panel directly. This also
allows removing the service_kind dashboard variable.

Note that Core DNS exposes this programming duration metric only for the
headless services with selector case
(coredns/coredns#3171)
so the service_kind filtering and variable is really not needed.

Co-authored-by: Istvan Zoltan Ballok <[email protected]>
  • Loading branch information
vicwicker and istvanballok committed Jul 4, 2024
1 parent 930f32b commit aafdb45
Showing 1 changed file with 13 additions and 48 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1049,21 +1049,23 @@
"fill": 0,
"fillGradient": 0,
"gridPos": {
"h": 8,
"w": 6,
"x": 6,
"h": 7,
"w": 24,
"x": 0,
"y": 58
},
"hiddenSeries": false,
"id": 33,
"legend": {
"avg": false,
"current": false,
"max": false,
"alignAsTable": true,
"avg": true,
"current": true,
"max": true,
"min": false,
"rightSide": true,
"show": true,
"total": false,
"values": false
"values": true
},
"lines": true,
"linewidth": 1,
Expand All @@ -1090,7 +1092,7 @@
"targets": [
{
"exemplar": true,
"expr": "increase(coredns_kubernetes_dns_programming_duration_seconds_sum{pod=~\"$pod\", service_kind=~\"$service_kind\"}[$__rate_interval])",
"expr": "sum(rate(coredns_kubernetes_dns_programming_duration_seconds_sum{pod=~\"$pod\"}[$__rate_interval])) by(service_kind)",
"interval": "",
"legendFormat": "{{pod}}",
"refId": "A"
Expand All @@ -1100,7 +1102,7 @@
"timeFrom": null,
"timeRegions": [],
"timeShift": null,
"title": "Increase in DNS Programming Seconds",
"title": "DNS Programming Cores",
"tooltip": {
"shared": true,
"sort": 0,
Expand All @@ -1117,7 +1119,7 @@
"yaxes": [
{
"$$hashKey": "object:557",
"format": "s",
"format": "cores",
"label": null,
"logBase": 1,
"max": null,
Expand Down Expand Up @@ -1161,7 +1163,7 @@
"h": 8,
"w": 12,
"x": 12,
"y": 58
"y": 65
},
"heatmap": {},
"hideZeroBuckets": true,
Expand Down Expand Up @@ -1257,43 +1259,6 @@
"tagsQuery": "",
"type": "query",
"useTags": false
},
{
"allValue": null,
"current": {
"selected": false,
"text": "headless_with_selector",
"value": "headless_with_selector"
},
"datasource": null,
"definition": "label_values(coredns_kubernetes_dns_programming_duration_seconds_count,service_kind)",
"description": null,
"error": null,
"hide": 2,
"includeAll": false,
"label": null,
"multi": false,
"name": "service_kind",
"options": [
{
"selected": true,
"text": "headless_with_selector",
"value": "headless_with_selector"
}
],
"query": {
"query": "label_values(coredns_kubernetes_dns_programming_duration_seconds_count,service_kind)",
"refId": "StandardVariableQuery"
},
"refresh": 0,
"regex": "",
"skipUrlSync": false,
"sort": 0,
"tagValuesQuery": "",
"tags": [],
"tagsQuery": "",
"type": "query",
"useTags": false
}
]
},
Expand Down

0 comments on commit aafdb45

Please sign in to comment.