Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test on maxabs_scale and PolynomialFeatures #1

Conversation

lowener
Copy link

@lowener lowener commented Apr 1, 2021

I'm adding tests on 3 features. I had to import numpy as cpu_np because numpy and cupy version of bincount are different.

Copy link
Owner

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions! Thanks for noticing the missing maxabs_scale function. Just noticed a few changes to do :

python/cuml/preprocessing/__init__.py Show resolved Hide resolved
python/cuml/test/test_preprocessing.py Outdated Show resolved Hide resolved
python/cuml/test/test_preprocessing.py Outdated Show resolved Hide resolved
@lowener lowener requested a review from viclafargue April 6, 2021 23:09
@lowener lowener changed the title Add test on add_dummy_feature + maxabs function + PolynomialFeatures Add test on maxabs_scale and PolynomialFeatures Apr 7, 2021
@viclafargue viclafargue merged commit b74f93b into viclafargue:preprocessing-out-of-experimental Apr 7, 2021
@lowener lowener deleted the preprocessing-out-of-experimental branch April 7, 2021 09:40
viclafargue pushed a commit that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants