feat: Expose HassClientWebSocket in HASSWSApi and EventHandlerSubscription events
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicfergar
changed the title
HassClientWebSocket in HASSWSApi and EventHandlerSubscription events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass HassClientWebSocket Instance as Event Sender
Problem
Currently, when receiving events from the Home Assistant instance, the
SocketEventSubscriptioninstance (an internal implementation detail) is passed as the sender in event handlers. This makes it difficult to access the actual WebSocket connection that received the event.Solution
Modified the event subscription system to pass the
HassClientWebSocketinstance as the sender instead of theSocketEventSubscription. This allows users to access the WebSocket connection that received the event and identify which Home Assistant instance triggered it.Related Issues
Fixes #14 - Determine which HA connection has returned AddEventHandlerSubscriptionAsync event