Add support for user added headers, like authentication tokens. #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geod24
requested changes
Sep 30, 2019
|
It should not break, I did tests locally. I guess it has to do with the spaces..
Why not?
Isn't that what overloads are for? |
Because your tests did not include a custom
The overload I mentioned does not call this overload. They should probably be unified though, as it looks like code duplication. |
ghost
closed this
s-ludwig
added a commit
that referenced
this pull request
Nov 23, 2019
This is an alternative to #2374.
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user can now create a websocket client with custom added req.headers.