Output null instead of undefined with Json.undefined serialization #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaloupka
commented
Apr 8, 2017
data/vibe/data/json.d
Outdated
| @@ -2010,7 +2016,6 @@ void writeJsonString(R, bool pretty = false)(ref R dst, in Json json, size_t lev | |||
| dst.put('{'); | |||
| bool first = true; | |||
| foreach (string k, ref const Json e; json.byKeyValue) { | |||
| if( e.type == Json.Type.undefined ) continue; | |||
There was a problem hiding this comment.
I've removed this because it will not serialize the attribute at all and I think, that this should be handled by @optional attribute.
There was a problem hiding this comment.
This is incorrect because Json.undefined literally means the key should not be present.
There was a problem hiding this comment.
Seconded. This was done to be consistent with the ECMA script spec, from which the undefined value originates.
tchaloupka
force-pushed
the
fix_#1735
branch
2 times, most recently
from
e5975db to
9baa162
Compare
s-ludwig
added a commit
that referenced
this pull request
Sep 2, 2017
Output null instead of undefined with Json.undefined serialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1735